github
/
ha-core
mirror of https://github.com/home-assistant/core
1
Fork 0
Code Releases Activity

Ring camera improvements (#22526) 

* Ring camera improvements

Expose last_video_id attribute.
Fix missing last_video_url
Only update last_video_id when video is ready

* Fix formatting
This commit is contained in:
Yaroslav 2019-03-29 21:10:00 +02:00 committed by Paulus Schoutsen
parent c31ab7a175
commit daf6b01b98
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
homeassistant/components/ring/camera.py
View File

@ -157,14 +157,23 @@ class RingCam(Camera):
self._camera.update()
self._utcnow = dt_util.utcnow()
last_recording_id = self._camera.last_recording_id
try:
last_event = self._camera.history(limit=1)[0]
except (IndexError, TypeError):
return
if self._last_video_id != last_recording_id or \
self._utcnow >= self._expires_at:
last_recording_id = last_event['id']
video_status = last_event['recording']['status']
_LOGGER.info("Ring DoorBell properties refreshed")
if video_status == 'ready' and \
(self._last_video_id != last_recording_id or
self._utcnow >= self._expires_at):
# update attributes if new video or if URL has expired
self._last_video_id = self._camera.last_recording_id
self._video_url = self._camera.recording_url(self._last_video_id)
self._expires_at = FORCE_REFRESH_INTERVAL + self._utcnow
video_url = self._camera.recording_url(last_recording_id)
if video_url:
_LOGGER.info("Ring DoorBell properties refreshed")
# update attributes if new video or if URL has expired
self._last_video_id = last_recording_id
self._video_url = video_url
self._expires_at = FORCE_REFRESH_INTERVAL + self._utcnow