From c22e106d44d1b3d2d591494376c3c4d2fbe227a2 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Tue, 22 Mar 2016 08:39:24 -0700 Subject: [PATCH] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c654a8c75e6f..44cf0bec545d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,16 +10,14 @@ **Checklist:** -- [ ] Local tests with `tox` run successfully. -- [ ] TravisCI does not fail. **Your PR cannot be merged unless CI is green!** -- [ ] [Fork is up to date][fork] and was rebased on the `dev` branch before creating the PR. -- [ ] Commits have been [squashed][squash]. -- If code communicates with devices: +If code communicates with devices: + - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass** - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]). - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]). - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`. - [ ] New files were added to `.coveragerc`. -- If the code does not interact with devices: + +If the code does not interact with devices: - [ ] Tests have been added to verify that the new code works. [fork]: http://stackoverflow.com/a/7244456