github
/
ha-core
mirror of https://github.com/home-assistant/core
1
Fork 0
Code Releases Activity

Remove incorrect ignore in pylint plugin (#90024) 

* Remove incorrect ignore_missing_annotations

* Allow tuple[int, int] in hs_color

* Adjust notify targets

* Always check for return type inheritance

* Adjust tests

* Revert "Always check for return type inheritance"

This reverts commit 3528742adf98edc6481f2c954c032ace881e1d6e.

* Revert "Allow tuple[int, int] in hs_color"

This reverts commit d51c1731eff3d59b9e94e7a7e914933ceaf8e34f.

* Revert "Adjust notify targets"

This reverts commit 4cba77a7309dc89980e29d6d5b9107d9e55f7070.
This commit is contained in:
epenet 2023-03-27 13:53:14 +02:00 committed by GitHub
parent 53de9dcdbc
commit c193402ba7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pylint/plugins/hass_enforce_type_hints.py
View File

@ -2974,9 +2974,7 @@ class HassTypeHintChecker(BaseChecker): # type: ignore[misc]
if class_matches := _CLASS_MATCH.get(module_platform):
self._class_matchers.extend(class_matches)
if not self.linter.config.ignore_missing_annotations and (
property_matches := _INHERITANCE_MATCH.get(module_platform)
):
if property_matches := _INHERITANCE_MATCH.get(module_platform):
self._class_matchers.extend(property_matches)
self._class_matchers.reverse()

2
tests/pylint/test_enforce_type_hints.py
View File

@ -574,7 +574,7 @@ def test_ignore_invalid_entity_properties(
async def async_lock(
self,
**kwargs
) -> bool:
):
pass
""",
"homeassistant.components.pylint_test.lock",