github/ha-core
1
Fork 0
mirror of https://github.com/home-assistant/core synced 2024-08-28 03:36:46 +02:00
Code Releases Activity

Only check known attributes in significant change support (#106572)

Browse Source 
only check known attributes
This commit is contained in:
Michael 2023-12-28 20:20:59 +01:00 committed by GitHub
parent 648afe121d
commit 756847eea8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 72 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
homeassistant/components/alarm_control_panel/significant_change.py
View File

@ -26,13 +26,16 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{k: v for k, v in old_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
new_attrs_s = set(
{k: v for k, v in new_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
for attr_name in changed_attrs:
if attr_name in SIGNIFICANT_ATTRIBUTES:
return True
if changed_attrs:
return True
# no significant attribute change detected
return False

12
homeassistant/components/climate/significant_change.py
View File

@ -52,15 +52,17 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{k: v for k, v in old_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
new_attrs_s = set(
{k: v for k, v in new_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
ha_unit = hass.config.units.temperature_unit
for attr_name in changed_attrs:
if attr_name not in SIGNIFICANT_ATTRIBUTES:
continue
if attr_name in [
ATTR_AUX_HEAT,
ATTR_FAN_MODE,

11
homeassistant/components/cover/significant_change.py
View File

@ -30,14 +30,15 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{k: v for k, v in old_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
new_attrs_s = set(
{k: v for k, v in new_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
for attr_name in changed_attrs:
if attr_name not in SIGNIFICANT_ATTRIBUTES:
continue
old_attr_value = old_attrs.get(attr_name)
new_attr_value = new_attrs.get(attr_name)
if new_attr_value is None or not check_valid_float(new_attr_value):

20
homeassistant/components/fan/significant_change.py
View File

@ -9,9 +9,14 @@ from homeassistant.helpers.significant_change import (
check_valid_float,
)
from . import ATTR_PERCENTAGE, ATTR_PERCENTAGE_STEP
from . import ATTR_DIRECTION, ATTR_OSCILLATING, ATTR_PERCENTAGE, ATTR_PRESET_MODE
INSIGNIFICANT_ATTRIBUTES: set[str] = {ATTR_PERCENTAGE_STEP}
SIGNIFICANT_ATTRIBUTES: set[str] = {
ATTR_DIRECTION,
ATTR_OSCILLATING,
ATTR_PERCENTAGE,
ATTR_PRESET_MODE,
}
@callback
@ -27,14 +32,15 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{k: v for k, v in old_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
new_attrs_s = set(
{k: v for k, v in new_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
for attr_name in changed_attrs:
if attr_name in INSIGNIFICANT_ATTRIBUTES:
continue
if attr_name != ATTR_PERCENTAGE:
return True

11
homeassistant/components/humidifier/significant_change.py
View File

@ -32,14 +32,15 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{k: v for k, v in old_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
new_attrs_s = set(
{k: v for k, v in new_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
for attr_name in changed_attrs:
if attr_name not in SIGNIFICANT_ATTRIBUTES:
continue
if attr_name in [ATTR_ACTION, ATTR_MODE]:
return True

19
homeassistant/components/media_player/significant_change.py
View File

@ -43,14 +43,23 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{
k: v
for k, v in old_attrs.items()
if k in SIGNIFICANT_ATTRIBUTES - INSIGNIFICANT_ATTRIBUTES
}.items()
)
new_attrs_s = set(
{
k: v
for k, v in new_attrs.items()
if k in SIGNIFICANT_ATTRIBUTES - INSIGNIFICANT_ATTRIBUTES
}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
for attr_name in changed_attrs:
if attr_name not in SIGNIFICANT_ATTRIBUTES - INSIGNIFICANT_ATTRIBUTES:
continue
if attr_name != ATTR_MEDIA_VOLUME_LEVEL:
return True

11
homeassistant/components/vacuum/significant_change.py
View File

@ -30,14 +30,15 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{k: v for k, v in old_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
new_attrs_s = set(
{k: v for k, v in new_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
for attr_name in changed_attrs:
if attr_name not in SIGNIFICANT_ATTRIBUTES:
continue
if attr_name != ATTR_BATTERY_LEVEL:
return True

11
homeassistant/components/water_heater/significant_change.py
View File

@ -42,15 +42,16 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{k: v for k, v in old_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
new_attrs_s = set(
{k: v for k, v in new_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
ha_unit = hass.config.units.temperature_unit
for attr_name in changed_attrs:
if attr_name not in SIGNIFICANT_ATTRIBUTES:
continue
if attr_name in [ATTR_OPERATION_MODE, ATTR_AWAY_MODE]:
return True

11
homeassistant/components/weather/significant_change.py
View File

@ -88,14 +88,15 @@ def async_check_significant_change(
if old_state != new_state:
return True
old_attrs_s = set(old_attrs.items())
new_attrs_s = set(new_attrs.items())
old_attrs_s = set(
{k: v for k, v in old_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
new_attrs_s = set(
{k: v for k, v in new_attrs.items() if k in SIGNIFICANT_ATTRIBUTES}.items()
)
changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
for attr_name in changed_attrs:
if attr_name not in SIGNIFICANT_ATTRIBUTES:
continue
old_attr_value = old_attrs.get(attr_name)
new_attr_value = new_attrs.get(attr_name)
absolute_change: float | None = None