Remove more useless manifest truthiness checks in hassfest (#82914)

This commit is contained in:
Aarni Koskela 2022-11-29 22:57:58 +02:00 committed by GitHub
parent 205a2ee215
commit 16fc2972d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 7 deletions

View File

@ -49,10 +49,7 @@ def generate_and_validate(integrations: dict[str, Integration], config: Config)
for domain in sorted(integrations):
integration = integrations[domain]
if (
not integration.manifest
or integration.manifest.get("integration_type") == "virtual"
):
if integration.integration_type == "virtual":
continue
codeowners = integration.manifest["codeowners"]

View File

@ -17,7 +17,7 @@ def _validate_integration(config: Config, integration: Integration) -> None:
config_flow_file = integration.path / "config_flow.py"
if not config_flow_file.is_file():
if (integration.manifest or {}).get("config_flow"):
if integration.manifest.get("config_flow"):
integration.add_error(
"config_flow",
"Config flows need to be defined in the file config_flow.py",
@ -149,7 +149,7 @@ def _generate_integrations(
primary_domains = {
domain
for domain, integration in integrations.items()
if integration.manifest and domain not in brand_integration_domains
if domain not in brand_integration_domains
}
# Add all brands to the set
primary_domains |= set(brands)

View File

@ -292,7 +292,7 @@ def validate_version(integration: Integration) -> None:
Will be removed when the version key is no longer optional for custom integrations.
"""
if not (integration.manifest and integration.manifest.get("version")):
if not integration.manifest.get("version"):
integration.add_error("manifest", "No 'version' key in the manifest file.")
return