mirror of https://github.com/bitcoin/bitcoin
409 lines
22 KiB
C++
409 lines
22 KiB
C++
// Copyright (c) 2021-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#include <common/system.h>
|
|
#include <policy/rbf.h>
|
|
#include <random.h>
|
|
#include <test/util/txmempool.h>
|
|
#include <txmempool.h>
|
|
#include <util/time.h>
|
|
|
|
#include <test/util/setup_common.h>
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
#include <optional>
|
|
#include <vector>
|
|
|
|
BOOST_FIXTURE_TEST_SUITE(rbf_tests, TestingSetup)
|
|
|
|
static inline CTransactionRef make_tx(const std::vector<CTransactionRef>& inputs,
|
|
const std::vector<CAmount>& output_values)
|
|
{
|
|
CMutableTransaction tx = CMutableTransaction();
|
|
tx.vin.resize(inputs.size());
|
|
tx.vout.resize(output_values.size());
|
|
for (size_t i = 0; i < inputs.size(); ++i) {
|
|
tx.vin[i].prevout.hash = inputs[i]->GetHash();
|
|
tx.vin[i].prevout.n = 0;
|
|
// Add a witness so wtxid != txid
|
|
CScriptWitness witness;
|
|
witness.stack.emplace_back(i + 10);
|
|
tx.vin[i].scriptWitness = witness;
|
|
}
|
|
for (size_t i = 0; i < output_values.size(); ++i) {
|
|
tx.vout[i].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
|
|
tx.vout[i].nValue = output_values[i];
|
|
}
|
|
return MakeTransactionRef(tx);
|
|
}
|
|
|
|
static CTransactionRef add_descendants(const CTransactionRef& tx, int32_t num_descendants, CTxMemPool& pool)
|
|
EXCLUSIVE_LOCKS_REQUIRED(::cs_main, pool.cs)
|
|
{
|
|
AssertLockHeld(::cs_main);
|
|
AssertLockHeld(pool.cs);
|
|
TestMemPoolEntryHelper entry;
|
|
// Assumes this isn't already spent in mempool
|
|
auto tx_to_spend = tx;
|
|
for (int32_t i{0}; i < num_descendants; ++i) {
|
|
auto next_tx = make_tx(/*inputs=*/{tx_to_spend}, /*output_values=*/{(50 - i) * CENT});
|
|
pool.addUnchecked(entry.FromTx(next_tx));
|
|
tx_to_spend = next_tx;
|
|
}
|
|
// Return last created tx
|
|
return tx_to_spend;
|
|
}
|
|
|
|
static CTransactionRef add_descendant_to_parents(const std::vector<CTransactionRef>& parents, CTxMemPool& pool)
|
|
EXCLUSIVE_LOCKS_REQUIRED(::cs_main, pool.cs)
|
|
{
|
|
AssertLockHeld(::cs_main);
|
|
AssertLockHeld(pool.cs);
|
|
TestMemPoolEntryHelper entry;
|
|
// Assumes this isn't already spent in mempool
|
|
auto child_tx = make_tx(/*inputs=*/parents, /*output_values=*/{50 * CENT});
|
|
pool.addUnchecked(entry.FromTx(child_tx));
|
|
// Return last created tx
|
|
return child_tx;
|
|
}
|
|
|
|
BOOST_FIXTURE_TEST_CASE(rbf_helper_functions, TestChain100Setup)
|
|
{
|
|
CTxMemPool& pool = *Assert(m_node.mempool);
|
|
LOCK2(::cs_main, pool.cs);
|
|
TestMemPoolEntryHelper entry;
|
|
|
|
const CAmount low_fee{CENT/100};
|
|
const CAmount normal_fee{CENT/10};
|
|
const CAmount high_fee{CENT};
|
|
|
|
// Create a parent tx1 and child tx2 with normal fees:
|
|
const auto tx1 = make_tx(/*inputs=*/ {m_coinbase_txns[0]}, /*output_values=*/ {10 * COIN});
|
|
pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx1));
|
|
const auto tx2 = make_tx(/*inputs=*/ {tx1}, /*output_values=*/ {995 * CENT});
|
|
pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx2));
|
|
|
|
// Create a low-feerate parent tx3 and high-feerate child tx4 (cpfp)
|
|
const auto tx3 = make_tx(/*inputs=*/ {m_coinbase_txns[1]}, /*output_values=*/ {1099 * CENT});
|
|
pool.addUnchecked(entry.Fee(low_fee).FromTx(tx3));
|
|
const auto tx4 = make_tx(/*inputs=*/ {tx3}, /*output_values=*/ {999 * CENT});
|
|
pool.addUnchecked(entry.Fee(high_fee).FromTx(tx4));
|
|
|
|
// Create a parent tx5 and child tx6 where both have very low fees
|
|
const auto tx5 = make_tx(/*inputs=*/ {m_coinbase_txns[2]}, /*output_values=*/ {1099 * CENT});
|
|
pool.addUnchecked(entry.Fee(low_fee).FromTx(tx5));
|
|
const auto tx6 = make_tx(/*inputs=*/ {tx5}, /*output_values=*/ {1098 * CENT});
|
|
pool.addUnchecked(entry.Fee(low_fee).FromTx(tx6));
|
|
// Make tx6's modified fee much higher than its base fee. This should cause it to pass
|
|
// the fee-related checks despite being low-feerate.
|
|
pool.PrioritiseTransaction(tx6->GetHash(), 1 * COIN);
|
|
|
|
// Two independent high-feerate transactions, tx7 and tx8
|
|
const auto tx7 = make_tx(/*inputs=*/ {m_coinbase_txns[3]}, /*output_values=*/ {999 * CENT});
|
|
pool.addUnchecked(entry.Fee(high_fee).FromTx(tx7));
|
|
const auto tx8 = make_tx(/*inputs=*/ {m_coinbase_txns[4]}, /*output_values=*/ {999 * CENT});
|
|
pool.addUnchecked(entry.Fee(high_fee).FromTx(tx8));
|
|
|
|
// Normal txs, will chain txns right before CheckConflictTopology test
|
|
const auto tx9 = make_tx(/*inputs=*/ {m_coinbase_txns[5]}, /*output_values=*/ {995 * CENT});
|
|
pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx9));
|
|
const auto tx10 = make_tx(/*inputs=*/ {m_coinbase_txns[6]}, /*output_values=*/ {995 * CENT});
|
|
pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx10));
|
|
|
|
// Will make these two parents of single child
|
|
const auto tx11 = make_tx(/*inputs=*/ {m_coinbase_txns[7]}, /*output_values=*/ {995 * CENT});
|
|
pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx11));
|
|
const auto tx12 = make_tx(/*inputs=*/ {m_coinbase_txns[8]}, /*output_values=*/ {995 * CENT});
|
|
pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx12));
|
|
|
|
const auto entry1_normal = pool.GetIter(tx1->GetHash()).value();
|
|
const auto entry2_normal = pool.GetIter(tx2->GetHash()).value();
|
|
const auto entry3_low = pool.GetIter(tx3->GetHash()).value();
|
|
const auto entry4_high = pool.GetIter(tx4->GetHash()).value();
|
|
const auto entry5_low = pool.GetIter(tx5->GetHash()).value();
|
|
const auto entry6_low_prioritised = pool.GetIter(tx6->GetHash()).value();
|
|
const auto entry7_high = pool.GetIter(tx7->GetHash()).value();
|
|
const auto entry8_high = pool.GetIter(tx8->GetHash()).value();
|
|
const auto entry9_unchained = pool.GetIter(tx9->GetHash()).value();
|
|
const auto entry10_unchained = pool.GetIter(tx10->GetHash()).value();
|
|
const auto entry11_unchained = pool.GetIter(tx11->GetHash()).value();
|
|
const auto entry12_unchained = pool.GetIter(tx12->GetHash()).value();
|
|
|
|
BOOST_CHECK_EQUAL(entry1_normal->GetFee(), normal_fee);
|
|
BOOST_CHECK_EQUAL(entry2_normal->GetFee(), normal_fee);
|
|
BOOST_CHECK_EQUAL(entry3_low->GetFee(), low_fee);
|
|
BOOST_CHECK_EQUAL(entry4_high->GetFee(), high_fee);
|
|
BOOST_CHECK_EQUAL(entry5_low->GetFee(), low_fee);
|
|
BOOST_CHECK_EQUAL(entry6_low_prioritised->GetFee(), low_fee);
|
|
BOOST_CHECK_EQUAL(entry7_high->GetFee(), high_fee);
|
|
BOOST_CHECK_EQUAL(entry8_high->GetFee(), high_fee);
|
|
|
|
CTxMemPool::setEntries set_12_normal{entry1_normal, entry2_normal};
|
|
CTxMemPool::setEntries set_34_cpfp{entry3_low, entry4_high};
|
|
CTxMemPool::setEntries set_56_low{entry5_low, entry6_low_prioritised};
|
|
CTxMemPool::setEntries set_78_high{entry7_high, entry8_high};
|
|
CTxMemPool::setEntries all_entries{entry1_normal, entry2_normal, entry3_low, entry4_high,
|
|
entry5_low, entry6_low_prioritised, entry7_high, entry8_high};
|
|
CTxMemPool::setEntries empty_set;
|
|
|
|
const auto unused_txid{GetRandHash()};
|
|
|
|
// Tests for PaysMoreThanConflicts
|
|
// These tests use feerate, not absolute fee.
|
|
BOOST_CHECK(PaysMoreThanConflicts(/*iters_conflicting=*/set_12_normal,
|
|
/*replacement_feerate=*/CFeeRate(entry1_normal->GetModifiedFee() + 1, entry1_normal->GetTxSize() + 2),
|
|
/*txid=*/unused_txid).has_value());
|
|
// Replacement must be strictly greater than the originals.
|
|
BOOST_CHECK(PaysMoreThanConflicts(set_12_normal, CFeeRate(entry1_normal->GetModifiedFee(), entry1_normal->GetTxSize()), unused_txid).has_value());
|
|
BOOST_CHECK(PaysMoreThanConflicts(set_12_normal, CFeeRate(entry1_normal->GetModifiedFee() + 1, entry1_normal->GetTxSize()), unused_txid) == std::nullopt);
|
|
// These tests use modified fees (including prioritisation), not base fees.
|
|
BOOST_CHECK(PaysMoreThanConflicts({entry5_low}, CFeeRate(entry5_low->GetModifiedFee() + 1, entry5_low->GetTxSize()), unused_txid) == std::nullopt);
|
|
BOOST_CHECK(PaysMoreThanConflicts({entry6_low_prioritised}, CFeeRate(entry6_low_prioritised->GetFee() + 1, entry6_low_prioritised->GetTxSize()), unused_txid).has_value());
|
|
BOOST_CHECK(PaysMoreThanConflicts({entry6_low_prioritised}, CFeeRate(entry6_low_prioritised->GetModifiedFee() + 1, entry6_low_prioritised->GetTxSize()), unused_txid) == std::nullopt);
|
|
// PaysMoreThanConflicts checks individual feerate, not ancestor feerate. This test compares
|
|
// replacement_feerate and entry4_high's feerate, which are the same. The replacement_feerate is
|
|
// considered too low even though entry4_high has a low ancestor feerate.
|
|
BOOST_CHECK(PaysMoreThanConflicts(set_34_cpfp, CFeeRate(entry4_high->GetModifiedFee(), entry4_high->GetTxSize()), unused_txid).has_value());
|
|
|
|
// Tests for EntriesAndTxidsDisjoint
|
|
BOOST_CHECK(EntriesAndTxidsDisjoint(empty_set, {tx1->GetHash()}, unused_txid) == std::nullopt);
|
|
BOOST_CHECK(EntriesAndTxidsDisjoint(set_12_normal, {tx3->GetHash()}, unused_txid) == std::nullopt);
|
|
BOOST_CHECK(EntriesAndTxidsDisjoint({entry2_normal}, {tx2->GetHash()}, unused_txid).has_value());
|
|
BOOST_CHECK(EntriesAndTxidsDisjoint(set_12_normal, {tx1->GetHash()}, unused_txid).has_value());
|
|
BOOST_CHECK(EntriesAndTxidsDisjoint(set_12_normal, {tx2->GetHash()}, unused_txid).has_value());
|
|
// EntriesAndTxidsDisjoint does not calculate descendants of iters_conflicting; it uses whatever
|
|
// the caller passed in. As such, no error is returned even though entry2_normal is a descendant of tx1.
|
|
BOOST_CHECK(EntriesAndTxidsDisjoint({entry2_normal}, {tx1->GetHash()}, unused_txid) == std::nullopt);
|
|
|
|
// Tests for PaysForRBF
|
|
const CFeeRate incremental_relay_feerate{DEFAULT_INCREMENTAL_RELAY_FEE};
|
|
const CFeeRate higher_relay_feerate{2 * DEFAULT_INCREMENTAL_RELAY_FEE};
|
|
// Must pay at least as much as the original.
|
|
BOOST_CHECK(PaysForRBF(/*original_fees=*/high_fee,
|
|
/*replacement_fees=*/high_fee,
|
|
/*replacement_vsize=*/1,
|
|
/*relay_fee=*/CFeeRate(0),
|
|
/*txid=*/unused_txid)
|
|
== std::nullopt);
|
|
BOOST_CHECK(PaysForRBF(high_fee, high_fee - 1, 1, CFeeRate(0), unused_txid).has_value());
|
|
BOOST_CHECK(PaysForRBF(high_fee + 1, high_fee, 1, CFeeRate(0), unused_txid).has_value());
|
|
// Additional fees must cover the replacement's vsize at incremental relay fee
|
|
BOOST_CHECK(PaysForRBF(high_fee, high_fee + 1, 2, incremental_relay_feerate, unused_txid).has_value());
|
|
BOOST_CHECK(PaysForRBF(high_fee, high_fee + 2, 2, incremental_relay_feerate, unused_txid) == std::nullopt);
|
|
BOOST_CHECK(PaysForRBF(high_fee, high_fee + 2, 2, higher_relay_feerate, unused_txid).has_value());
|
|
BOOST_CHECK(PaysForRBF(high_fee, high_fee + 4, 2, higher_relay_feerate, unused_txid) == std::nullopt);
|
|
BOOST_CHECK(PaysForRBF(low_fee, high_fee, 99999999, incremental_relay_feerate, unused_txid).has_value());
|
|
BOOST_CHECK(PaysForRBF(low_fee, high_fee + 99999999, 99999999, incremental_relay_feerate, unused_txid) == std::nullopt);
|
|
|
|
// Tests for GetEntriesForConflicts
|
|
CTxMemPool::setEntries all_parents{entry1_normal, entry3_low, entry5_low, entry7_high, entry8_high};
|
|
CTxMemPool::setEntries all_children{entry2_normal, entry4_high, entry6_low_prioritised};
|
|
const std::vector<CTransactionRef> parent_inputs({m_coinbase_txns[0], m_coinbase_txns[1], m_coinbase_txns[2],
|
|
m_coinbase_txns[3], m_coinbase_txns[4]});
|
|
const auto conflicts_with_parents = make_tx(parent_inputs, {50 * CENT});
|
|
CTxMemPool::setEntries all_conflicts;
|
|
BOOST_CHECK(GetEntriesForConflicts(/*tx=*/ *conflicts_with_parents.get(),
|
|
/*pool=*/ pool,
|
|
/*iters_conflicting=*/ all_parents,
|
|
/*all_conflicts=*/ all_conflicts) == std::nullopt);
|
|
BOOST_CHECK(all_conflicts == all_entries);
|
|
auto conflicts_size = all_conflicts.size();
|
|
all_conflicts.clear();
|
|
|
|
add_descendants(tx2, 23, pool);
|
|
BOOST_CHECK(GetEntriesForConflicts(*conflicts_with_parents.get(), pool, all_parents, all_conflicts) == std::nullopt);
|
|
conflicts_size += 23;
|
|
BOOST_CHECK_EQUAL(all_conflicts.size(), conflicts_size);
|
|
all_conflicts.clear();
|
|
|
|
add_descendants(tx4, 23, pool);
|
|
BOOST_CHECK(GetEntriesForConflicts(*conflicts_with_parents.get(), pool, all_parents, all_conflicts) == std::nullopt);
|
|
conflicts_size += 23;
|
|
BOOST_CHECK_EQUAL(all_conflicts.size(), conflicts_size);
|
|
all_conflicts.clear();
|
|
|
|
add_descendants(tx6, 23, pool);
|
|
BOOST_CHECK(GetEntriesForConflicts(*conflicts_with_parents.get(), pool, all_parents, all_conflicts) == std::nullopt);
|
|
conflicts_size += 23;
|
|
BOOST_CHECK_EQUAL(all_conflicts.size(), conflicts_size);
|
|
all_conflicts.clear();
|
|
|
|
add_descendants(tx7, 23, pool);
|
|
BOOST_CHECK(GetEntriesForConflicts(*conflicts_with_parents.get(), pool, all_parents, all_conflicts) == std::nullopt);
|
|
conflicts_size += 23;
|
|
BOOST_CHECK_EQUAL(all_conflicts.size(), conflicts_size);
|
|
BOOST_CHECK_EQUAL(all_conflicts.size(), 100);
|
|
all_conflicts.clear();
|
|
|
|
// Exceeds maximum number of conflicts.
|
|
add_descendants(tx8, 1, pool);
|
|
BOOST_CHECK(GetEntriesForConflicts(*conflicts_with_parents.get(), pool, all_parents, all_conflicts).has_value());
|
|
|
|
// Tests for HasNoNewUnconfirmed
|
|
const auto spends_unconfirmed = make_tx({tx1}, {36 * CENT});
|
|
for (const auto& input : spends_unconfirmed->vin) {
|
|
// Spends unconfirmed inputs.
|
|
BOOST_CHECK(pool.exists(GenTxid::Txid(input.prevout.hash)));
|
|
}
|
|
BOOST_CHECK(HasNoNewUnconfirmed(/*tx=*/ *spends_unconfirmed.get(),
|
|
/*pool=*/ pool,
|
|
/*iters_conflicting=*/ all_entries) == std::nullopt);
|
|
BOOST_CHECK(HasNoNewUnconfirmed(*spends_unconfirmed.get(), pool, {entry2_normal}) == std::nullopt);
|
|
BOOST_CHECK(HasNoNewUnconfirmed(*spends_unconfirmed.get(), pool, empty_set).has_value());
|
|
|
|
const auto spends_new_unconfirmed = make_tx({tx1, tx8}, {36 * CENT});
|
|
BOOST_CHECK(HasNoNewUnconfirmed(*spends_new_unconfirmed.get(), pool, {entry2_normal}).has_value());
|
|
BOOST_CHECK(HasNoNewUnconfirmed(*spends_new_unconfirmed.get(), pool, all_entries).has_value());
|
|
|
|
const auto spends_conflicting_confirmed = make_tx({m_coinbase_txns[0], m_coinbase_txns[1]}, {45 * CENT});
|
|
BOOST_CHECK(HasNoNewUnconfirmed(*spends_conflicting_confirmed.get(), pool, {entry1_normal, entry3_low}) == std::nullopt);
|
|
|
|
// Tests for CheckConflictTopology
|
|
|
|
// Tx4 has 23 descendants
|
|
BOOST_CHECK(pool.CheckConflictTopology(set_34_cpfp).has_value());
|
|
|
|
// No descendants yet
|
|
BOOST_CHECK(pool.CheckConflictTopology({entry9_unchained}) == std::nullopt);
|
|
|
|
// Add 1 descendant, still ok
|
|
add_descendants(tx9, 1, pool);
|
|
BOOST_CHECK(pool.CheckConflictTopology({entry9_unchained}) == std::nullopt);
|
|
|
|
// N direct conflicts; ok
|
|
BOOST_CHECK(pool.CheckConflictTopology({entry9_unchained, entry10_unchained, entry11_unchained}) == std::nullopt);
|
|
|
|
// Add 1 descendant, still ok, even if it's considered a direct conflict as well
|
|
const auto child_tx = add_descendants(tx10, 1, pool);
|
|
const auto entry10_child = pool.GetIter(child_tx->GetHash()).value();
|
|
BOOST_CHECK(pool.CheckConflictTopology({entry9_unchained, entry10_unchained, entry11_unchained}) == std::nullopt);
|
|
BOOST_CHECK(pool.CheckConflictTopology({entry9_unchained, entry10_unchained, entry11_unchained, entry10_child}) == std::nullopt);
|
|
|
|
// One more, size 3 cluster too much
|
|
const auto grand_child_tx = add_descendants(child_tx, 1, pool);
|
|
const auto entry10_grand_child = pool.GetIter(grand_child_tx->GetHash()).value();
|
|
BOOST_CHECK_EQUAL(pool.CheckConflictTopology({entry9_unchained, entry10_unchained, entry11_unchained}).value(), strprintf("%s has 2 descendants, max 1 allowed", entry10_unchained->GetSharedTx()->GetHash().ToString()));
|
|
// even if direct conflict is descendent itself
|
|
BOOST_CHECK_EQUAL(pool.CheckConflictTopology({entry9_unchained, entry10_grand_child, entry11_unchained}).value(), strprintf("%s has 2 ancestors, max 1 allowed", entry10_grand_child->GetSharedTx()->GetHash().ToString()));
|
|
|
|
// Make a single child from two singleton parents
|
|
const auto two_parent_child_tx = add_descendant_to_parents({tx11, tx12}, pool);
|
|
const auto entry_two_parent_child = pool.GetIter(two_parent_child_tx->GetHash()).value();
|
|
BOOST_CHECK_EQUAL(pool.CheckConflictTopology({entry11_unchained}).value(), strprintf("%s is not the only parent of child %s", entry11_unchained->GetSharedTx()->GetHash().ToString(), entry_two_parent_child->GetSharedTx()->GetHash().ToString()));
|
|
BOOST_CHECK_EQUAL(pool.CheckConflictTopology({entry12_unchained}).value(), strprintf("%s is not the only parent of child %s", entry12_unchained->GetSharedTx()->GetHash().ToString(), entry_two_parent_child->GetSharedTx()->GetHash().ToString()));
|
|
BOOST_CHECK_EQUAL(pool.CheckConflictTopology({entry_two_parent_child}).value(), strprintf("%s has 2 ancestors, max 1 allowed", entry_two_parent_child->GetSharedTx()->GetHash().ToString()));
|
|
}
|
|
|
|
BOOST_FIXTURE_TEST_CASE(improves_feerate, TestChain100Setup)
|
|
{
|
|
CTxMemPool& pool = *Assert(m_node.mempool);
|
|
LOCK2(::cs_main, pool.cs);
|
|
TestMemPoolEntryHelper entry;
|
|
|
|
const CAmount low_fee{CENT/100};
|
|
const CAmount normal_fee{CENT/10};
|
|
|
|
// low feerate parent with normal feerate child
|
|
const auto tx1 = make_tx(/*inputs=*/ {m_coinbase_txns[0]}, /*output_values=*/ {10 * COIN});
|
|
pool.addUnchecked(entry.Fee(low_fee).FromTx(tx1));
|
|
const auto tx2 = make_tx(/*inputs=*/ {tx1}, /*output_values=*/ {995 * CENT});
|
|
pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx2));
|
|
|
|
const auto entry1 = pool.GetIter(tx1->GetHash()).value();
|
|
const auto tx1_fee = entry1->GetModifiedFee();
|
|
const auto tx1_size = entry1->GetTxSize();
|
|
const auto entry2 = pool.GetIter(tx2->GetHash()).value();
|
|
const auto tx2_fee = entry2->GetModifiedFee();
|
|
const auto tx2_size = entry2->GetTxSize();
|
|
|
|
// Now test ImprovesFeerateDiagram with various levels of "package rbf" feerates
|
|
|
|
// It doesn't improve itself
|
|
const auto res1 = ImprovesFeerateDiagram(pool, {entry1}, {entry1, entry2}, tx1_fee + tx2_fee, tx1_size + tx2_size);
|
|
BOOST_CHECK(res1.has_value());
|
|
BOOST_CHECK(res1.value().first == DiagramCheckError::FAILURE);
|
|
BOOST_CHECK(res1.value().second == "insufficient feerate: does not improve feerate diagram");
|
|
|
|
// With one more satoshi it does
|
|
BOOST_CHECK(ImprovesFeerateDiagram(pool, {entry1}, {entry1, entry2}, tx1_fee + tx2_fee + 1, tx1_size + tx2_size) == std::nullopt);
|
|
|
|
// Adding a grandchild makes the cluster size 3, which is uncalculable
|
|
const auto tx3 = make_tx(/*inputs=*/ {tx2}, /*output_values=*/ {995 * CENT});
|
|
pool.addUnchecked(entry.Fee(normal_fee).FromTx(tx3));
|
|
const auto res3 = ImprovesFeerateDiagram(pool, {entry1}, {entry1, entry2}, tx1_fee + tx2_fee + 1, tx1_size + tx2_size);
|
|
BOOST_CHECK(res3.has_value());
|
|
BOOST_CHECK(res3.value().first == DiagramCheckError::UNCALCULABLE);
|
|
BOOST_CHECK(res3.value().second == strprintf("%s has 2 descendants, max 1 allowed", tx1->GetHash().GetHex()));
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(feerate_diagram_utilities)
|
|
{
|
|
// Sanity check the correctness of the feerate diagram comparison.
|
|
|
|
// A strictly better case.
|
|
std::vector<FeeFrac> old_diagram{{FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}}};
|
|
std::vector<FeeFrac> new_diagram{{FeeFrac{0, 0}, FeeFrac{1000, 300}, FeeFrac{1050, 400}}};
|
|
|
|
BOOST_CHECK(std::is_lt(CompareFeerateDiagram(old_diagram, new_diagram)));
|
|
|
|
// Incomparable diagrams
|
|
old_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}};
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{1000, 300}, FeeFrac{1000, 400}};
|
|
|
|
BOOST_CHECK(CompareFeerateDiagram(old_diagram, new_diagram) == std::partial_ordering::unordered);
|
|
|
|
// Strictly better but smaller size.
|
|
old_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}};
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{1100, 300}};
|
|
|
|
BOOST_CHECK(std::is_lt(CompareFeerateDiagram(old_diagram, new_diagram)));
|
|
|
|
// New diagram is strictly better due to the first chunk, even though
|
|
// second chunk contributes no fees
|
|
old_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}};
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{1100, 100}, FeeFrac{1100, 200}};
|
|
|
|
BOOST_CHECK(std::is_lt(CompareFeerateDiagram(old_diagram, new_diagram)));
|
|
|
|
// Feerate of first new chunk is better with, but second chunk is worse
|
|
old_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}};
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{750, 100}, FeeFrac{999, 350}, FeeFrac{1150, 1000}};
|
|
|
|
BOOST_CHECK(CompareFeerateDiagram(old_diagram, new_diagram) == std::partial_ordering::unordered);
|
|
|
|
// If we make the second chunk slightly better, the new diagram now wins.
|
|
old_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}};
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{750, 100}, FeeFrac{1000, 350}, FeeFrac{1150, 500}};
|
|
|
|
BOOST_CHECK(std::is_lt(CompareFeerateDiagram(old_diagram, new_diagram)));
|
|
|
|
// Identical diagrams, cannot be strictly better
|
|
old_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}};
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}};
|
|
|
|
BOOST_CHECK(std::is_eq(CompareFeerateDiagram(old_diagram, new_diagram)));
|
|
|
|
// Same aggregate fee, but different total size (trigger single tail fee check step)
|
|
old_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 399}};
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}};
|
|
|
|
// No change in evaluation when tail check needed.
|
|
BOOST_CHECK(std::is_gt(CompareFeerateDiagram(old_diagram, new_diagram)));
|
|
|
|
// Padding works on either argument
|
|
BOOST_CHECK(std::is_lt(CompareFeerateDiagram(new_diagram, old_diagram)));
|
|
|
|
// Trigger multiple tail fee check steps
|
|
old_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 399}};
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}, FeeFrac{1050, 401}, FeeFrac{1050, 402}};
|
|
|
|
BOOST_CHECK(std::is_gt(CompareFeerateDiagram(old_diagram, new_diagram)));
|
|
BOOST_CHECK(std::is_lt(CompareFeerateDiagram(new_diagram, old_diagram)));
|
|
|
|
// Multiple tail fee check steps, unordered result
|
|
new_diagram = {FeeFrac{0, 0}, FeeFrac{950, 300}, FeeFrac{1050, 400}, FeeFrac{1050, 401}, FeeFrac{1050, 402}, FeeFrac{1051, 403}};
|
|
BOOST_CHECK(CompareFeerateDiagram(old_diagram, new_diagram) == std::partial_ordering::unordered);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|