mirror of
https://github.com/bitcoin/bitcoin
synced 2024-09-07 06:40:15 +02:00
d6d402bd2b
Very old shells suffered from bugs which meant that prefixing variables with an "x" to ensure that the lefthand side of a comparison always started with an alphanumeric character was needed. Modern shells don't suffer from this issue (i.e Bash was fixed in 1996). In any case, we've already got unprefixed checks used in our codebase, i.e https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L292, and have dependencies (in depends) that also use unprefixed comparisons. I think it's time that we can consolidate on not using the x-prefix workaround. At best it's mostly just confusing. More info: https://github.com/koalaman/shellcheck/wiki/SC2268 https://www.vidarholen.net/contents/blog/?p=1035
19 lines
796 B
Plaintext
19 lines
796 B
Plaintext
dnl Copyright (c) 2013-2014 The Bitcoin Core developers
|
|
dnl Distributed under the MIT software license, see the accompanying
|
|
dnl file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
dnl BITCOIN_SUBDIR_TO_INCLUDE([CPPFLAGS-VARIABLE-NAME],[SUBDIRECTORY-NAME],[HEADER-FILE])
|
|
dnl SUBDIRECTORY-NAME must end with a path separator
|
|
AC_DEFUN([BITCOIN_SUBDIR_TO_INCLUDE],[
|
|
if test "$2" = ""; then
|
|
AC_MSG_RESULT([default])
|
|
else
|
|
echo "#include <$2$3.h>" >conftest.cpp
|
|
newinclpath=`${CXXCPP} ${CPPFLAGS} -M conftest.cpp 2>/dev/null | [ tr -d '\\n\\r\\\\' | sed -e 's/^.*[[:space:]:]\(\/[^[:space:]]*\)]$3[\.h[[:space:]].*$/\1/' -e t -e d`]
|
|
AC_MSG_RESULT([${newinclpath}])
|
|
if test "${newinclpath}" != ""; then
|
|
eval "$1=\"\$$1\"' -I${newinclpath}'"
|
|
fi
|
|
fi
|
|
])
|