bitcoin/src/test
merge-script eb0bdbdd75
Merge bitcoin/bitcoin#28657: miniscript: make operator""_mst consteval
63317103c9 miniscript: make operator_mst consteval (Pieter Wuille)

Pull request description:

  It seems modern compilers don't realize that all invocations of operator""_mst can be evaluated at compile time, despite the `constexpr` keyword.

  Since C++20, we can force them to evaluate at compile time using `consteval`, turning all the miniscript type constants into actual compile-time constants.

  This should give a nice but not very important speedup for miniscript logic, but it's also a way to start testing C++20 features.

ACKs for top commit:
  hebasto:
    re-ACK 63317103c9.
  theuni:
    utACK 63317103c9

Tree-SHA512: bdc9f1a6499b8bb3ca04f1a158c31e6876ba97206f95ee5718f50efd58b5b4e6b8867c07f791848430bfaa130b9676d8a68320b763cda9a340c75527acbfcc9e
2024-05-04 09:13:11 +08:00
..
data Add test for negative transaction version w/ CSV to tx_valid.json 2024-01-11 15:05:01 -06:00
fuzz miniscript: make operator_mst consteval 2024-05-03 11:38:14 -04:00
util [refactor] make MempoolAcceptResult::m_replaced_transactions non-optional 2024-05-01 13:34:37 +01:00
.gitignore test: add ipc test to test multiprocess type conversion code 2023-11-28 12:35:50 -05:00
Makefile
README.md Merge bitcoin/bitcoin#26564: test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-11 07:03:02 -04:00
addrman_tests.cpp doc, test: Test and explain service flag handling 2024-01-15 16:19:53 -05:00
allocator_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
amount_tests.cpp test: Add tests for CFeeRate multiplication operator 2023-12-11 16:27:58 -05:00
argsman_tests.cpp test: Fix debug recommendation in argsman_tests 2024-04-04 14:55:46 +02:00
arith_uint256_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
banman_tests.cpp
base32_tests.cpp
base58_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
base64_tests.cpp
bech32_tests.cpp
bip32_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
bip324_tests.cpp crypto: Spanify EllSwiftPubKey constructor 2023-09-07 08:53:45 -04:00
blockchain_tests.cpp refactor: rpc: Pass CBlockIndex by reference instead of pointer 2023-12-07 12:05:21 +01:00
blockencodings_tests.cpp refactor: Simplify `extra_txn` to be a vec of CTransactionRef instead of a vec of pair<Wtxid, CTransactionRef> 2024-04-06 19:17:20 +01:00
blockfilter_index_tests.cpp refactor: share and use `GenerateRandomKey` helper 2023-12-23 13:26:00 +01:00
blockfilter_tests.cpp Remove unused includes from blockfilter.h 2023-08-17 18:28:15 +02:00
blockmanager_tests.cpp refactor: Remove calls to StartShutdown from KernelNotifications 2023-12-04 15:39:15 -04:00
bloom_tests.cpp Remove unused CDataStream 2023-11-30 11:27:54 +01:00
bswap_tests.cpp serialization: detect byteswap builtins without autoconf tests 2024-02-28 13:42:38 +00:00
checkqueue_tests.cpp refactor: Make `CCheckQueue` constructor start worker threads 2023-10-03 10:52:15 +01:00
coins_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
coinstatsindex_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
common_url_tests.cpp test: Add two more urlDecode tests 2024-04-26 08:33:56 +02:00
compilerbug_tests.cpp
compress_tests.cpp test: add script compression coverage for not-on-curve P2PK outputs 2024-01-22 13:38:48 +01:00
crypto_tests.cpp crypto: replace CountBits with std::bit_width 2024-02-26 16:13:12 +00:00
cuckoocache_tests.cpp
dbwrapper_tests.cpp
denialofservice_tests.cpp Remove timedata 2024-04-10 17:01:27 +02:00
descriptor_tests.cpp wallet: fix key parsing check for miniscript expressions in `ParseScript` 2023-12-08 06:54:00 -03:00
disconnected_transactions.cpp [test] DisconnectedBlockTransactions::DynamicMemoryUsage 2023-10-19 16:14:36 +01:00
feefrac_tests.cpp Avoid explicitly computing diagram; compare based on chunks 2024-04-22 09:36:36 -04:00
flatfile_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
fs_tests.cpp Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup 2023-12-14 16:46:54 -05:00
getarg_tests.cpp scripted-diff: move settings to common namespace 2023-05-30 17:26:51 +02:00
hash_tests.cpp Drop CHashWriter 2023-11-14 08:45:32 +10:00
headers_sync_chainwork_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
httpserver_tests.cpp
i2p_tests.cpp i2p: construct Session with Proxy instead of CService 2024-03-01 14:47:29 -05:00
interfaces_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
ipc_test.capnp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.cpp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.h multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_tests.cpp test: add ipc test to test multiprocess type conversion code 2023-11-28 12:35:50 -05:00
key_io_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
key_tests.cpp Unit test for ellswift creation/decoding roundtrip 2023-06-23 14:22:39 -04:00
logging_tests.cpp logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace 2023-12-20 15:59:48 +10:00
main.cpp test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-07 10:11:45 -07:00
mempool_tests.cpp refactor: Drop util::Result operator= 2024-04-25 16:08:24 -04:00
merkle_tests.cpp
merkleblock_tests.cpp refactor: Use Txid in CMerkleBlock 2023-11-28 17:49:41 +01:00
miner_tests.cpp refactor: Fix timedata includes 2024-02-01 13:52:05 +01:00
miniminer_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
miniscript_tests.cpp [clang-tidy] Enable the misc-no-recursion check 2024-04-07 14:04:45 +01:00
minisketch_tests.cpp
multisig_tests.cpp
net_peer_connection_tests.cpp Rename version.h to node/protocol_version.h 2023-11-30 11:28:31 +01:00
net_peer_eviction_tests.cpp
net_tests.cpp Remove timedata 2024-04-10 17:01:27 +02:00
netbase_tests.cpp Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections 2024-02-28 10:05:56 -03:00
orphanage_tests.cpp [unit test] TxOrphanage::GetChildrenFrom* 2024-04-26 10:28:27 +01:00
peerman_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
pmt_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
policy_fee_tests.cpp [net processing] FeeFilterRounder doesn't own a FastRandomContext 2023-10-04 13:16:52 +01:00
policyestimator_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
pool_tests.cpp pool: change memusage_test to use int64_t, add allocation check 2023-11-20 17:10:34 +01:00
pow_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
prevector_tests.cpp
raii_event_tests.cpp
random_tests.cpp test: move remaining random test util code from setup_common to random 2023-06-14 08:28:33 -06:00
rbf_tests.cpp Avoid explicitly computing diagram; compare based on chunks 2024-04-22 09:36:36 -04:00
rest_tests.cpp
result_tests.cpp
reverselock_tests.cpp
rpc_tests.cpp Merge bitcoin/bitcoin#29277: RPC: access RPC arguments by name 2024-04-29 10:38:50 -04:00
sanity_tests.cpp Revert "time: add runtime sanity check" 2024-03-18 16:01:08 +01:00
scheduler_tests.cpp scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner 2024-02-15 14:43:14 +01:00
script_p2sh_tests.cpp tests: test both settings for permitbaremultisig in p2sh tests 2023-12-15 18:37:24 +10:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp refactor: share and use `GenerateRandomKey` helper 2023-12-23 13:26:00 +01:00
script_tests.cpp sign: don't assume we are parsing a sane Miniscript 2024-04-22 18:24:35 +02:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp serfloat: improve/simplify tests 2024-02-20 11:33:32 +00:00
serialize_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
settings_tests.cpp init: improve corrupted/empty settings file error msg 2024-01-22 10:50:03 -03:00
sighash_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
sigopcount_tests.cpp refactor: share and use `GenerateRandomKey` helper 2023-12-23 13:26:00 +01:00
skiplist_tests.cpp
sock_tests.cpp test: improve sock_tests/move_assignment 2023-08-28 14:32:17 +02:00
span_tests.cpp Fix CI-detected codespell warnings 2024-02-23 23:01:07 +01:00
streams_tests.cpp test: Fix `test/streams_tests.cpp` compilation on SunOS / illumos 2024-04-18 10:53:32 +01:00
sync_tests.cpp
system_tests.cpp refactor: Rename `subprocess.hpp` to follow our header name conventions 2024-04-23 18:22:58 +01:00
timeoffsets_tests.cpp Add TimeOffsets helper class 2024-04-10 17:01:27 +02:00
torcontrol_tests.cpp
transaction_tests.cpp Merge bitcoin/bitcoin#28948: v3 transaction policy for anti-pinning 2024-02-09 23:37:57 -05:00
translation_tests.cpp
txindex_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
txpackage_tests.cpp [txpackages] add canonical way to get hash of package 2024-04-26 10:28:27 +01:00
txreconciliation_tests.cpp
txrequest_tests.cpp
txvalidation_tests.cpp [unit test] sibling not returned from SingleV3Checks if 1p2c or 3gen 2024-03-01 15:23:04 +00:00
txvalidationcache_tests.cpp [refactor] Add missing includes for next commit 2023-09-12 22:51:42 +02:00
uint256_tests.cpp Merge bitcoin/bitcoin#28924: refactor: Remove unused and fragile string interface from arith_uint256 2023-12-07 16:02:05 +00:00
util_tests.cpp refactor: FormatISO8601* without gmtime* 2024-03-18 16:01:24 +01:00
util_threadnames_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
validation_block_tests.cpp [clang-tidy] Enable the misc-no-recursion check 2024-04-07 14:04:45 +01:00
validation_chainstate_tests.cpp refactor, test: Always initialize pointer 2024-05-02 23:10:05 +01:00
validation_chainstatemanager_tests.cpp assumeutxo: Remove BLOCK_ASSUMED_VALID flag 2024-03-18 11:28:40 -05:00
validation_flush_tests.cpp
validation_tests.cpp test: removes unnecessary check from validation_tests 2024-02-29 09:54:47 -05:00
validationinterface_tests.cpp scripted-diff: Rename MainSignals to ValidationSignals 2024-02-15 14:45:51 +01:00
versionbits_tests.cpp doc: fix typos 2023-11-07 10:21:51 +09:00
xoroshiro128plusplus_tests.cpp

README.md

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check, which includes unit tests from subtrees, or make && make -C src check-unit for just the unit tests.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example.

test_bitcoin also accepts some of the command line arguments accepted by bitcoind. Use -- to separate these sets of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes sends debug logging, which normally goes only to debug.log within the data directory, also to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

test_bitcoin creates a temporary working (data) directory with a randomly generated pathname within test_common_Bitcoin Core/, which in turn is within the system's temporary directory (see temp_directory_path). This data directory looks like a simplified form of the standard bitcoind data directory. Its content will vary depending on the test, but it will always have a debug.log file, for example.

The location of the temporary data directory can be specified with the -testdatadir option. This can make debugging easier. The directory path used is the argument path appended with /test_common_Bitcoin Core/<test-name>/datadir. The directory path is created if necessary. Specifying this argument also causes the data directory not to be removed after the last test. This is useful for looking at what the test wrote to debug.log after it completes, for example. (The directory is removed at the start of the next test run, so no leftover state is used.)

$ test_bitcoin --run_test=getarg_tests/doubledash -- -testdatadir=/somewhere/mydatadir
Test directory (will not be deleted): "/somewhere/mydatadir/test_common_Bitcoin Core/getarg_tests/doubledash/datadir
Running 1 test case...

*** No errors detected
$ ls -l '/somewhere/mydatadir/test_common_Bitcoin Core/getarg_tests/doubledash/datadir'
total 8
drwxrwxr-x 2 admin admin 4096 Nov 27 22:45 blocks
-rw-rw-r-- 1 admin admin 1003 Nov 27 22:45 debug.log

If you run an entire test suite, such as --run_test=getarg_tests, or all the test suites (by not specifying --run_test), a separate directory will be created for each individual test.

Run test_bitcoin --help for the full list of tests.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred