github
/
bitcoin
mirror of https://github.com/bitcoin/bitcoin
1
Fork 0
Code Releases Activity

test: fix `addnode` functional test failure on OpenBSD 

This is the functional test counterpart of PR #28891 /
commit 007d6f0e85.
This commit is contained in:
Sebastian Falbesoner 2023-12-08 18:23:01 +01:00
parent 3e691258d8
commit fd0bde2793
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/functional/rpc_net.py
View File

@ -9,6 +9,7 @@ Tests correspond to code in rpc/net.cpp.
from decimal import Decimal
from itertools import product
import platform
import time
import test_framework.messages
@ -220,8 +221,10 @@ class NetTest(BitcoinTestFramework):
ip_port = "127.0.0.1:{}".format(p2p_port(2))
self.nodes[0].addnode(node=ip_port, command='add')
# try to add an equivalent ip
ip_port2 = "127.1:{}".format(p2p_port(2))
assert_raises_rpc_error(-23, "Node already added", self.nodes[0].addnode, node=ip_port2, command='add')
# (note that OpenBSD doesn't support the IPv4 shorthand notation with omitted zero-bytes)
if platform.system() != "OpenBSD":
ip_port2 = "127.1:{}".format(p2p_port(2))
assert_raises_rpc_error(-23, "Node already added", self.nodes[0].addnode, node=ip_port2, command='add')
# check that the node has indeed been added
added_nodes = self.nodes[0].getaddednodeinfo()
assert_equal(len(added_nodes), 1)