github
/
bitcoin
mirror of https://github.com/bitcoin/bitcoin
1
Fork 0
Code Releases Activity

test: Add test for createwalletdescriptor

This commit is contained in:
Ava Chow 2023-12-22 12:55:59 -05:00
parent 2402b63062
commit 746b6d8839
2 changed files with 124 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/functional/test_runner.py
View File

@ -182,6 +182,7 @@ BASE_SCRIPTS = [
'wallet_keypool_topup.py --descriptors',
'wallet_fast_rescan.py --descriptors',
'wallet_gethdkeys.py --descriptors',
'wallet_createwalletdescriptor.py --descriptors',
'interface_zmq.py',
'rpc_invalid_address_message.py',
'rpc_validateaddress.py',

123
test/functional/wallet_createwalletdescriptor.py Executable file
View File

@ -0,0 +1,123 @@
#!/usr/bin/env python3
# Copyright (c) 2023 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""Test wallet createwalletdescriptor RPC."""
from test_framework.descriptors import descsum_create
from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import (
assert_equal,
assert_raises_rpc_error,
)
from test_framework.wallet_util import WalletUnlock
class WalletCreateDescriptorTest(BitcoinTestFramework):
def add_options(self, parser):
self.add_wallet_options(parser, descriptors=True, legacy=False)
def set_test_params(self):
self.setup_clean_chain = True
self.num_nodes = 1
def skip_test_if_missing_module(self):
self.skip_if_no_wallet()
def run_test(self):
self.test_basic()
self.test_imported_other_keys()
self.test_encrypted()
def test_basic(self):
def_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
self.nodes[0].createwallet("blank", blank=True)
wallet = self.nodes[0].get_wallet_rpc("blank")
xpub_info = def_wallet.gethdkeys(private=True)
xpub = xpub_info[0]["xpub"]
xprv = xpub_info[0]["xprv"]
expected_descs = []
for desc in def_wallet.listdescriptors()["descriptors"]:
if desc["desc"].startswith("wpkh("):
expected_descs.append(desc["desc"])
assert_raises_rpc_error(-5, "Unable to determine which HD key to use from active descriptors. Please specify with 'hdkey'", wallet.createwalletdescriptor, "bech32")
assert_raises_rpc_error(-5, f"Private key for {xpub} is not known", wallet.createwalletdescriptor, type="bech32", hdkey=xpub)
self.log.info("Test createwalletdescriptor after importing active descriptor to blank wallet")
# Import one active descriptor
assert_equal(wallet.importdescriptors([{"desc": descsum_create(f"pkh({xprv}/44h/2h/0h/0/0/*)"), "timestamp": "now", "active": True}])[0]["success"], True)
assert_equal(len(wallet.listdescriptors()["descriptors"]), 1)
assert_equal(len(wallet.gethdkeys()), 1)
new_descs = wallet.createwalletdescriptor("bech32")["descs"]
assert_equal(len(new_descs), 2)
assert_equal(len(wallet.gethdkeys()), 1)
assert_equal(new_descs, expected_descs)
self.log.info("Test descriptor creation options")
old_descs = set([(d["desc"], d["active"], d["internal"]) for d in wallet.listdescriptors(private=True)["descriptors"]])
wallet.createwalletdescriptor(type="bech32m", internal=False)
curr_descs = set([(d["desc"], d["active"], d["internal"]) for d in wallet.listdescriptors(private=True)["descriptors"]])
new_descs = list(curr_descs - old_descs)
assert_equal(len(new_descs), 1)
assert_equal(len(wallet.gethdkeys()), 1)
assert_equal(new_descs[0][0], descsum_create(f"tr({xprv}/86h/1h/0h/0/*)"))
assert_equal(new_descs[0][1], True)
assert_equal(new_descs[0][2], False)
old_descs = curr_descs
wallet.createwalletdescriptor(type="bech32m", internal=True)
curr_descs = set([(d["desc"], d["active"], d["internal"]) for d in wallet.listdescriptors(private=True)["descriptors"]])
new_descs = list(curr_descs - old_descs)
assert_equal(len(new_descs), 1)
assert_equal(len(wallet.gethdkeys()), 1)
assert_equal(new_descs[0][0], descsum_create(f"tr({xprv}/86h/1h/0h/1/*)"))
assert_equal(new_descs[0][1], True)
assert_equal(new_descs[0][2], True)
def test_imported_other_keys(self):
self.log.info("Test createwalletdescriptor with multiple keys in active descriptors")
def_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
self.nodes[0].createwallet("multiple_keys")
wallet = self.nodes[0].get_wallet_rpc("multiple_keys")
wallet_xpub = wallet.gethdkeys()[0]["xpub"]
xpub_info = def_wallet.gethdkeys(private=True)
xpub = xpub_info[0]["xpub"]
xprv = xpub_info[0]["xprv"]
assert_equal(wallet.importdescriptors([{"desc": descsum_create(f"wpkh({xprv}/0/0/*)"), "timestamp": "now", "active": True}])[0]["success"], True)
assert_equal(len(wallet.gethdkeys()), 2)
assert_raises_rpc_error(-5, "Unable to determine which HD key to use from active descriptors. Please specify with 'hdkey'", wallet.createwalletdescriptor, "bech32")
assert_raises_rpc_error(-4, "Descriptor already exists", wallet.createwalletdescriptor, type="bech32m", hdkey=wallet_xpub)
assert_raises_rpc_error(-5, "Unable to parse HD key. Please provide a valid xpub", wallet.createwalletdescriptor, type="bech32m", hdkey=xprv)
# Able to replace tr() descriptor with other hd key
wallet.createwalletdescriptor(type="bech32m", hdkey=xpub)
def test_encrypted(self):
self.log.info("Test createwalletdescriptor with encrypted wallets")
def_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
self.nodes[0].createwallet("encrypted", blank=True, passphrase="pass")
wallet = self.nodes[0].get_wallet_rpc("encrypted")
xpub_info = def_wallet.gethdkeys(private=True)
xprv = xpub_info[0]["xprv"]
with WalletUnlock(wallet, "pass"):
assert_equal(wallet.importdescriptors([{"desc": descsum_create(f"wpkh({xprv}/0/0/*)"), "timestamp": "now", "active": True}])[0]["success"], True)
assert_equal(len(wallet.gethdkeys()), 1)
assert_raises_rpc_error(-13, "Error: Please enter the wallet passphrase with walletpassphrase first.", wallet.createwalletdescriptor, type="bech32m")
with WalletUnlock(wallet, "pass"):
wallet.createwalletdescriptor(type="bech32m")
if __name__ == '__main__':
WalletCreateDescriptorTest().main()