github
/
bitcoin
mirror of https://github.com/bitcoin/bitcoin
1
Fork 0
Code Releases Activity

remove unneeded bufsize option from cpp-subprocess

This commit is contained in:
Sebastian Falbesoner 2024-04-16 14:11:21 +02:00
parent 79c3036373
commit 03ffb09c31
1 changed files with 1 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/util/subprocess.hpp
View File

@ -631,16 +631,6 @@ namespace util
* -------------------------------
*/
/*!
* The buffer size of the stdin/stdout/stderr
* streams of the child process.
* Default value is 0.
*/
struct bufsize {
explicit bufsize(int sz): bufsiz(sz) {}
int bufsiz = 0;
};
/*!
* Base class for all arguments involving string value.
*/
@ -910,7 +900,6 @@ struct ArgumentDeducer
void set_option(executable&& exe);
void set_option(cwd&& cwdir);
void set_option(bufsize&& bsiz);
void set_option(environment&& env);
void set_option(input&& inp);
void set_option(output&& out);
@ -1065,9 +1054,6 @@ public:// Yes they are public
HANDLE g_hChildStd_ERR_Wr = nullptr;
#endif
// Buffer size for the IO streams
int bufsiz_ = 0;
// Pipes for communicating with child
// Emulates stdin
@ -1525,10 +1511,6 @@ namespace detail {
popen_->cwd_ = std::move(cwdir.arg_value);
}
inline void ArgumentDeducer::set_option(bufsize&& bsiz) {
popen_->stream_.bufsiz_ = bsiz.bufsiz;
}
inline void ArgumentDeducer::set_option(environment&& env) {
popen_->env_ = std::move(env.env_);
}
@ -1658,16 +1640,7 @@ namespace detail {
for (auto& h : handles) {
if (h == nullptr) continue;
switch (bufsiz_) {
case 0:
setvbuf(h, nullptr, _IONBF, BUFSIZ);
break;
case 1:
setvbuf(h, nullptr, _IONBF, BUFSIZ);
break;
default:
setvbuf(h, nullptr, _IOFBF, bufsiz_);
};
setvbuf(h, nullptr, _IONBF, BUFSIZ);
}
#endif
}