1
mirror of https://github.com/carlospolop/PEASS-ng synced 2024-11-20 12:39:21 +01:00

Refactor peasLoaded.py for Improved Efficiency

This pull request introduces a set of improvements to the peasLoaded.py file, aimed at enhancing the readability, maintainability, and performance of the code. The key changes include:

- Indentation Correction: Fixed the indentation to comply with Python standards, ensuring proper code block recognition and avoiding potential runtime errors.

- List Comprehension: Implemented list comprehension for the creation of FileRecord instances, which simplifies the code structure and improves readability.

- Configuration Handling: Streamlined the access to the config dictionary by extracting it once at the beginning of the loop, reducing repetitive code and potential access errors.

- Default Value Usage: Utilized the .get() method with default values from DEFAULTS for both `auto_check` and `exec` keys.

These changes do not alter the core functionality of the code but provide a cleaner and more efficient approach to the existing logic.

Please review the changes and let me know if there are any concerns or further improvements that can be made.
This commit is contained in:
Dante 2024-05-05 14:50:25 +02:00 committed by GitHub
parent 972503f806
commit fa5578b2ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -6,26 +6,24 @@ class PEASLoaded:
def __init__(self):
to_search = YAML_LOADED["search"]
self.peasrecords = []
for record in to_search:
record_value = record["value"]
if "linpeas" in str(record_value["config"].get("disable","")).lower():
config = record_value.get("config", {})
if "linpeas" in config.get("disable", "").lower():
continue
filerecords = []
for filerecord in record_value["files"]:
filerecords.append(
FileRecord(
regex=filerecord["name"],
**filerecord["value"]
)
)
filerecords = [
FileRecord(regex=filerecord["name"], **filerecord["value"])
for filerecord in record_value["files"]
]
name = record["name"]
self.peasrecords.append(
PEASRecord(
name=name,
auto_check=record_value["config"]["auto_check"],
exec=record_value["config"].get("exec", DEFAULTS["exec"]),
name=record["name"],
auto_check=config.get("auto_check", DEFAULTS["auto_check"]),
exec=config.get("exec", DEFAULTS["exec"]),
filerecords=filerecords
)
)
)